Links containing underscore do not work

[42ske]

Describe the bug
If an md-File ends with a link containing an underscore the link is not working anymore if you open the file the next time. "_“ is replaced by "_".

If you have a link-Text without _ the link still works, e.g. „Link" contains https://docs.nextcloud.com/server/stable/user_manual/de/files/projects.html

To Reproduce
Steps to reproduce the behavior:

1. Open a md-file.
2. Add a link containing an underscore as last text within the file (no further letters following) e. g. https://docs.nextcloud.com/server/stable/user_manual/de/files/projects.html
3. close the file (or finish the file within Collectives)
4. reopen the file an click on the link

Expected behavior
No changes should be done in Link-Texts so that they just work.

Client details:

• OS: macOS 12.3.1
• Browser: Firefox 100.0

Are the following infos necessary in this case?

Thanks for having a look.

Server details

Text app version: (see Nextcloud apps page)

Operating system:

Web server:

Database:

PHP version:

Nextcloud version: (see Nextcloud admin page)

Logs

Nextcloud log (data/nextcloud.log)

Insert your Nextcloud log here

Browser log

Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log
c) ...

[mejo-]

Thanks for your report! Which Nextcloud version do you use?

I was able to reproduce this on Nextcloud 23, but not on Nextcloud 24.

We recently updated the markdown input/paste rules in Nextcloud 22 and 23: #1964
This seems to be fixed with the migration to Tiptap v2.

[42ske]

I found the error on Nextcloud 23. I just tested it on a 24-installation. There I cannot reproduce the bug.

[susnux]

@juliushaertl This should be fixed with NC 23.0.6 by updating prosemirror-markdown to >= 1.6.2 (was updated to 1.8.0).
As this is fixed by ProseMirror/prosemirror-markdown#67

So probably this could stay closed?

[mejo-]

Indeed, verified that it's closed.

[jancborchardt]

@mejo- I just ran into this with the version we have deployed on our instance – seems the problem is back or still there?
Example link e.g. https://www.bitvtest.de/bitv_test/das_testverfahren_im_detail/verfahren.html

[jancborchardt]

Ah nevermind – that was actually a link pasted before the fix, and I guess that would be difficult to distinguish? Newly pasted links work well. :)