ViewerComponent: pass on autofocus to EditorWrapper #1645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azul
force-pushed
the
expose-autofocus-prop
branch
from
48ddc0d to
a463c9f
Compare
juliusknorr
approved these changes
Jun 10, 2021
Member
|
Hm, where has the node check gone :/ |
Member
|
Ah it only runs on push which is then probably not happening on a fork. @azul Could you build and commit the updated bundles as well? |
The `ViewerComponent` is reused in the collectives app. Allow disabling autofocus when using the viewer component. Signed-off-by: Azul <[email protected]>
azul
force-pushed
the
expose-autofocus-prop
branch
from
a463c9f to
1b5457e
Compare
Contributor
Author
|
@juliushaertl like so? ( |
Member
|
Yes, looks good 👍 |
Member
|
/backport to stable21 |
Member
|
/backport to stable20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ViewerComponentis reused in the collectives app.Allow disabling autofocus when using the viewer component.