Skip to content

Some Design fixes #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
szaimen merged 1 commit into from
Jul 9, 2021
Merged

Some Design fixes #1710

szaimen merged 1 commit into from
Jul 9, 2021

Conversation

@szaimen
Copy link
Contributor

@szaimen szaimen commented Jul 8, 2021 •
edited
Loading

Desktop

Before After
image image

Mobile (iPhone 5s display)

Before After
image image

Mobile (Google Pixel 2 display)

Before After
image image

Signed-off-by: szaimen [email protected]

@szaimen szaimen added enhancement New feature or request design Experience, interaction, interface, … 3. to review labels Jul 8, 2021
@szaimen szaimen added this to the Nextcloud 23 milestone Jul 8, 2021
@szaimen szaimen force-pushed the enh/noid/design-fixes branch from 789fbb4 to 1e51a4c Compare July 8, 2021 13:32
@szaimen
Copy link
Contributor Author

szaimen commented Jul 8, 2021

/compile amend /

@szaimen @npmbuildbot-nextcloud
Some Design fixes
7172ad1 
Signed-off-by: szaimen <[email protected]>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the enh/noid/design-fixes branch from 1e51a4c to 7172ad1 Compare July 8, 2021 13:53
Pytal
Pytal reviewed Jul 8, 2021
View reviewed changes
Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a before and after :)

@szaimen
Copy link
Contributor Author

szaimen commented Jul 8, 2021 •
edited
Loading

Can we get a before and after :)

Updated the description :)

@szaimen szaimen requested a review from skjnldsv July 9, 2021 10:34
@szaimen szaimen merged commit 53093aa into master Jul 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the enh/noid/design-fixes branch July 9, 2021 12:01
@szaimen
Copy link
Contributor Author

szaimen commented Jul 9, 2021

/backport to stable22

@szaimen
Copy link
Contributor Author

szaimen commented Jul 9, 2021

/backport to stable21

@szaimen
Copy link
Contributor Author

szaimen commented Jul 9, 2021

/backport to stable20

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jul 9, 2021

The backport to stable21 failed. Please do this backport manually.

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 9, 2021
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jul 9, 2021

The backport to stable20 failed. Please do this backport manually.

@szaimen
Copy link
Contributor Author

szaimen commented Jul 9, 2021

Right, then I am not bothering to backport to stable20 and stable21

This was referenced Jul 9, 2021
Closed
Closed
@szaimen
Copy link
Contributor Author

szaimen commented Jul 20, 2021

/backport to stable21

@szaimen
Copy link
Contributor Author

szaimen commented Jul 20, 2021

/backport to stable20

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jul 20, 2021

The backport to stable21 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jul 20, 2021

The backport to stable20 failed. Please do this backport manually.

@szaimen
Copy link
Contributor Author

szaimen commented Jul 20, 2021

/backport to stable21

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jul 20, 2021

The backport to stable21 failed. Please do this backport manually.

@szaimen
Copy link
Contributor Author

szaimen commented Jul 20, 2021

/backport to stable20

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jul 20, 2021

The backport to stable20 failed. Please do this backport manually.

This was referenced Jul 22, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pytal Pytal Pytal left review comments

@nimishavijay nimishavijay nimishavijay approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@artonge artonge Awaiting requested review from artonge

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

No one assigned

Labels

3. to review design Experience, interaction, interface, … enhancement New feature or request

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

4 participants

@szaimen @Pytal @nimishavijay