Azul/fix links 1676 #1775
Merged
Azul/fix links 1676 #1775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like the [accessor to state] was removed from the Viewer api and replaced with [separate getters]. So we need to replace `OCA.Viewer.state.file` with `OCA.Viewer.file`. Fixes #1676 [accessor to state]: (nextcloud/viewer@dbfa6bc#diff-c29528ea58a2d0307765d4357b88c9a469c148ccca2d82b653dbb97290ab6ab1L52-L63) [separate getters]: (nextcloud/viewer@dbfa6bc#diff-c29528ea58a2d0307765d4357b88c9a469c148ccca2d82b653dbb97290ab6ab1R79-R81) Signed-off-by: Azul <[email protected]>
juliusknorr
approved these changes
Jul 19, 2021
Member
|
Drone seems confused about the stable22 branch change. @azul The usual flow would be to have a PR against master and then do the backport but let me forward port that one then for now. |
Member
|
/backport to master |
|
The backport to master failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update use of
OCA.Viewerapi to the nextcloud 22 versionLooks like the accessor to state was removed from the Viewer api
and replaced with separate getters.
So we need to replace
OCA.Viewer.state.filewithOCA.Viewer.file.