fix: resolve relative image path based on currentDirectory option #1800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azul
requested review from
juliusknorr and
mejo-
and removed request for
juliusknorr
Contributor
Author
|
/compile amend / updates:
|
azul
force-pushed
the
azul/fix-relative-image
branch
3 times, most recently
from
284d612 to
14dafb2
Compare
Member
|
@azul Mind to do a rebase :) |
juliusknorr
approved these changes
Aug 2, 2021
azul
force-pushed
the
azul/fix-relative-image
branch
from
14dafb2 to
7ac6dde
Compare
This approach is more reliable because it does not rely on the files app. Therefor it also works in `talk` and `collectives`. Fixes #1780. Use the currentDirectory to determine dav paths for gif files and display the animated gif via dav rather than the preview that lacks animation. Also display webp files with dav urls. Fixes #1655. Signed-off-by: Azul <[email protected]>
azul
force-pushed
the
azul/fix-relative-image
branch
from
7ac6dde to
115bc0d
Compare
azul
added a commit
that referenced
this pull request
Nov 10, 2021
Preserve urls that start with `core/preview` no matter if `hasPreview` is in there or not. Also do not add a duplicate `/` in dav urls. `this.filePath` already starts with a `/`. Add a test for dav paths and fix some others that were broken by #1800.
azul
added a commit
that referenced
this pull request
Nov 10, 2021
Preserve urls that start with `core/preview` no matter if `hasPreview` is in there or not. Also do not add a duplicate `/` in dav urls. `this.filePath` already starts with a `/`. Add a test for dav paths and fix some others that were broken by #1800.
azul
added a commit
that referenced
this pull request
Nov 10, 2021
Preserve urls that start with `core/preview` no matter if `hasPreview` is in there or not. Also do not add a duplicate `/` in dav urls. `this.filePath` already starts with a `/`. Add a test for dav paths and fix some others that were broken by #1800. Signed-off-by: Azul <[email protected]>
azul
added a commit
that referenced
this pull request
Nov 10, 2021
Preserve urls that start with `core/preview` no matter if `hasPreview` is in there or not. Also do not add a duplicate `/` in dav urls. `this.filePath` already starts with a `/`. Add a test for dav paths and fix some others that were broken by #1800. Signed-off-by: Azul <[email protected]>
azul
added a commit
that referenced
this pull request
Nov 11, 2021
Preserve urls that start with `core/preview` no matter if `hasPreview` is in there or not. Also do not add a duplicate `/` in dav urls. `this.filePath` already starts with a `/`. Add a test for dav paths and fix some others that were broken by #1800. Signed-off-by: Azul <[email protected]>
backportbot-nextcloud bot
pushed a commit
that referenced
this pull request
Nov 11, 2021
Preserve urls that start with `core/preview` no matter if `hasPreview` is in there or not. Also do not add a duplicate `/` in dav urls. `this.filePath` already starts with a `/`. Add a test for dav paths and fix some others that were broken by #1800. Signed-off-by: Azul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Display relative Images without fileId in talk and collectives
Hand
currentDirctorytoImageplugin.This approach is more reliable because it does not rely on the files app.
Therefor it also works in
talkandcollectives.Fixes #1780.
We already know the current files path in the Editor.
Just need to pass it down like we do for the
MenuBubble.Display animated gifs
Use the
currentDirectoryto determine dav paths for gif filesand display the animated gif via dav rather than the preview
that lacks animation.
Support webp
Also display webp files with dav urls. Fixes #1655.
Signed-off-by: Azul [email protected]