Skip to content

fix: cypress icon close selector #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 1 commit into from
Aug 2, 2021
Merged

fix: cypress icon close selector #1804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: cypress icon close selector 
The markup of the close icon has changed.

See nextcloud/viewer@f7bcfd0
for a similar fix to the viewer itself.

Signed-off-by: Azul <[email protected]>
  • Loading branch information
@azul
azul committed Aug 2, 2021
commit 6112b7257a6728f3c2a14fe27f149837038e0422
4 changes: 2 additions & 2 deletions cypress/integration/viewer.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ describe('Open test.md in viewer', function() {
cy.get('#viewer').should('be.visible')
cy.get('#viewer .modal-title').should('contain', 'test.md')
cy.get('#viewer .modal-header button.action-item__menutoggle').should('be.visible')
cy.get('#viewer .modal-header button.icon-close').should('be.visible')
cy.get('#viewer .modal-header button.header-close').should('be.visible')

cy.wait(2000)
cy.get('#viewer', { timeout: 4000 })
Expand All @@ -75,7 +75,7 @@ describe('Open test.md in viewer', function() {
})

it('Closes the editor', function() {
cy.get('.modal-header button.icon-close').click()
cy.get('.modal-header button.header-close').click()
cy.get('#viewer').should('not.exist')
})

Expand Down