Skip to content

[stable22] fix: cypress icon close selector #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliusknorr merged 1 commit into from
Aug 2, 2021
Merged

[stable22] fix: cypress icon close selector #1808

juliusknorr merged 1 commit into from
Aug 2, 2021

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Aug 2, 2021

backport of #1804

@azul @backportbot
fix: cypress icon close selector
a190265 
The markup of the close icon has changed.

See nextcloud/viewer@f7bcfd0
for a similar fix to the viewer itself.

Signed-off-by: Azul <[email protected]>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 22.1.0 milestone Aug 2, 2021
@juliusknorr
Copy link
Member

juliusknorr commented Aug 2, 2021

  1. Open test.md in viewer
    Shares the file as a public read only link:
    AssertionError: Timed out retrying after 4000ms: Expected to find element: #app-sidebar-vue button.new-share-link, but never found it.
    at Context.eval (http://localhost:8081/__cypress/tests?p=cypress/integration/share.spec.js:68:8)

Seems unrelated so maybe a somewhat flaky test

@azul
Copy link
Contributor

azul commented Aug 2, 2021 

1. Open test.md in viewer
   Shares the file as a public read only link:
   AssertionError: Timed out retrying after 4000ms: Expected to find element: `#app-sidebar-vue button.new-share-link`, but never found it.
   at Context.eval (http://localhost:8081/__cypress/tests?p=cypress/integration/share.spec.js:68:8)

I don't see that anymore... was the test rerun?
I also suspect a flaky test.

@juliusknorr
Copy link
Member

juliusknorr commented Aug 2, 2021

Yes, I restarted the action. Let's get that in then.

@juliusknorr juliusknorr merged commit a76e669 into stable22 Aug 2, 2021
@juliusknorr juliusknorr deleted the backport/1804/stable22 branch August 2, 2021 18:56
@skjnldsv skjnldsv mentioned this pull request Aug 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azul azul azul approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@mejo- mejo- Awaiting requested review from mejo-

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Nextcloud 22.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@juliusknorr @azul