Skip to content

Only show image author annotations if needed #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
azul merged 1 commit into from
Oct 25, 2021
Merged

Only show image author annotations if needed #1888

azul merged 1 commit into from
Oct 25, 2021

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Oct 6, 2021

Fixes #1779

@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Oct 6, 2021
azul
azul approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@azul azul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@azul azul force-pushed the bugfix/1779 branch 2 times, most recently from c3bac33 to c0add53 Compare October 20, 2021 10:34
@azul azul merged commit dca0e66 into master Oct 25, 2021
@delete-merged-branch delete-merged-branch bot deleted the bugfix/1779 branch October 25, 2021 09:05
@juliusknorr
Copy link
Member Author

juliusknorr commented Oct 25, 2021

/backport to stable22

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Oct 25, 2021

The backport to stable22 failed. Please do this backport manually.

@skjnldsv skjnldsv mentioned this pull request Oct 25, 2021
Merged
25 tasks
@max-nextcloud
Copy link
Collaborator

max-nextcloud commented Jan 13, 2022

/backport to stable22

@max-nextcloud
Copy link
Collaborator

max-nextcloud commented Jan 13, 2022

... trying to figure out why backports to stable22 keep failing.

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 13, 2022

The backport to stable22 failed. Please do this backport manually.

@juliusknorr juliusknorr mentioned this pull request Jan 13, 2022
Closed
@juliusknorr
Copy link
Member Author

juliusknorr commented Jan 13, 2022

I'll take care of the backport

@juliusknorr juliusknorr mentioned this pull request Jan 13, 2022
Merged
@juliusknorr
Copy link
Member Author

juliusknorr commented Jan 13, 2022

Seems the changed js asset names caused the problem with the backport bot here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azul azul azul approved these changes

@mejo- mejo- Awaiting requested review from mejo-

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud

Assignees

No one assigned

Labels

4. to release bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Images always have author colors

4 participants

@juliusknorr @max-nextcloud @azul