Insert images from local device (or link)

[julien-nc]

Fixes #58

Here is a basic implementation of 2 new options to insert images:

• Upload from local device
• Download from http link

In both cases, the image is then stored in the /Text directory which is created if it does not exist.
An alternative mentioned in #58 (comment) would be to store uploaded images in a directory next to the markdown file.

Todo

• Menu action for local file insertion
• Handling file upload
• Display uploaded image
• Handle and display upload errors
• Menu action for image link insertion
• Handling link download/store
• Display image from link
• Handle and display link insertion errors
• Change menu item naming
• Change attachment folder name
• Use the attachment folder when inserting images from Files
• Handle .md file copy/move/delete with File events
• Cleanup attachment folder when images are removed from markdown content

Gifcording 😁

[julien-nc]

This now includes "attachment folder" changes. It's been rebased on master (so it must be used in NC 24).

The TODO list in this PR's description has been updated.

[juliusknorr]

• To be discussed if we still need the original file for gif support for example

[julien-nc]

This has been changed and will work if we want to support GIFs. If the mime type is not supported by the preview generator, the original file is returned now. This also fixes the svg display because there is no related preview provider by default.

[julien-nc]

/compile amend

[mejo-]

We can now merge or wait until a pairing session about Cypress and some more tests. As you wish.

I don't mind to merge now and add cypress tests later (if we don't forget about it 😬). But the failing psalm tests should be tackled first, no?

[julien-nc]

/compile amend

[mejo-]

Super nice work 👌

[juliusknorr]

Filed #2049 for the cypress tests

[tobiasKaminsky]

Is this also ready for clients via our DirectEditingMobileInterface?

[julien-nc]

@tobiasKaminsky All related endpoints are public and use the session edition token and optionally the public share token to authenticate.
So it is supposed to be ok but in reality it partially works. I've tried it on our Android app:

• Inserting an image from a link ✔️
• Uploading a local image ❌ The <input type=file> does not work when rendered in the Android app.
• Serving the images ❌ 2 mistakes:
  • The share token presence detection is broken in
  • The ImageController does not get the user ID from the session

I'll make a PR to fix the 2 image serving issues.
I don't know about the local image upload issue. Do you think we should just hide this feature on mobile apps? Or is there a way to get a system file selector when clicking on such file input?

[tobiasKaminsky]

I don't know about the local image upload issue. Do you think we should just hide this feature on mobile apps? Or is there a way to get a system file selector when clicking on such file input?

This is possible, as we do it with Collabora.

In this regard, we have this nextcloud/server#16132, but want to wait for your side (move RichDocuments to directEditing)