Fix wrong generation of ocs url for rich workspaces #1904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <[email protected]>
Member
Author
|
No backports needed as the router bump was only done to master for 23. |
Member
Author
|
Might be a good case to add a cypress test for showing rich workspaces |
azul
approved these changes
Oct 20, 2021
Contributor
azul
left a comment
azul
left a comment
There was a problem hiding this comment.
Looks good to me. I think this is good to go. Maybe we should have a separate issue for the missing test.
Member
Author
|
Filed #1905 for that |
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found when testing #1860 and also encountered by @azul
This was a regression introduced with #1565 where the ocs path for fetching rich workspace details was not properly constructed anymore.