Skip to content

[stable22] Fix header popover in richworkspace #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TSI-kavitasonawane wants to merge 2 commits into from
Closed

[stable22] Fix header popover in richworkspace #1940

TSI-kavitasonawane wants to merge 2 commits into from

Conversation

@TSI-kavitasonawane
Copy link

@TSI-kavitasonawane TSI-kavitasonawane commented Nov 9, 2021 •
edited by juliusknorr
Loading

backport of #1821

@juliusknorr
Copy link
Member

juliusknorr commented Nov 9, 2021

Could you please provide some details on what this fix does, ideally with some before/after screenshots.

@TSI-kavitasonawane
Copy link
Author

TSI-kavitasonawane commented Nov 9, 2021 •
edited
Loading

Could you please provide some details on what this fix does, ideally with some before/after screenshots.
Summary
Previously the popover for the header in the file browser was cut off. Now instead of making the whole text editor scrollable, only the content is.
@juliushaertl I have referred below Pull request link to fix the issue. This issue is already fixed for version 23.

#1821

Before:
textarea header

After:
heading popover

@juliusknorr juliusknorr changed the title Fix header popover in richworkspace [stable22] Fix header popover in richworkspace Dec 8, 2021
@juliusknorr juliusknorr added 3. to review bug Something isn't working labels Dec 8, 2021
@juliusknorr juliusknorr mentioned this pull request Dec 8, 2021
Merged
@juliusknorr
Copy link
Member

juliusknorr commented Dec 8, 2021

I've rebased the changes again and pushed to a new PR: #2003

@juliusknorr juliusknorr closed this Dec 8, 2021
@juliusknorr juliusknorr deleted the nmcfeat/757-Fix-header-popover-in-richworkspace branch December 8, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

3. to review bug Something isn't working

Projects

None yet

Milestone

Nextcloud 22.2.4

Development

Successfully merging this pull request may close these issues.

2 participants

@TSI-kavitasonawane @juliusknorr