Hide menu and keep focus when using menubar popover items #1959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable22 |
julien-nc
approved these changes
Nov 26, 2021
Member
julien-nc
left a comment
julien-nc
left a comment
There was a problem hiding this comment.
Code looks good. Works perfectly.
mejo-
approved these changes
Nov 26, 2021
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
bugfix/noid/mobile-menu-popover
branch
from
0a52a7b to
93e3a09
Compare
|
The backport to stable22 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using any formatting action from the collapsed menubar, this change will make sure that the popover gets hidden and the focus stays within the document.