Skip to content

Don't show "Link file" button when using direct edition #1978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
julien-nc merged 1 commit into from
Dec 2, 2021
Merged

Don't show "Link file" button when using direct edition #1978

julien-nc merged 1 commit into from
Dec 2, 2021

Conversation

@julien-nc
Copy link
Member

@julien-nc julien-nc commented Dec 2, 2021

closes #1975
This uses the initial state to determine if we are using direct edition.

@julien-nc julien-nc added this to the Nextcloud 24 milestone Dec 2, 2021
mejo-
mejo- approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good codewise. I'm unable to test this easily.

juliusknorr
juliusknorr approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for taking care 👍

@juliusknorr
Copy link
Member

juliusknorr commented Dec 2, 2021

Looks good codewise. I'm unable to test this easily.

Just in case needed for the future, there are API examples expandable in the description of nextcloud/server#17625, but let me open an issue to move that to the documentation actually.

@juliusknorr
Copy link
Member

juliusknorr commented Dec 2, 2021

/rebase

@juliusknorr
Copy link
Member

juliusknorr commented Dec 2, 2021

Filed nextcloud/.github#28 to improve the rebase/compile automation as long as we have bundles committed.

@juliusknorr
Copy link
Member

juliusknorr commented Dec 2, 2021

/backport to stable23

@juliusknorr
Copy link
Member

juliusknorr commented Dec 2, 2021

/backport to stable22

@julien-nc julien-nc force-pushed the fix/1975/hide-link-file-if-direct-editing branch from 4a10d33 to 3c561b1 Compare December 2, 2021 14:13
@julien-nc
Copy link
Member Author

julien-nc commented Dec 2, 2021

Filed nextcloud/.github#28 to improve the rebase/compile automation as long as we have bundles committed.

Nice to think we'll be able to avoid those long rebase with compiled assets 😁.

@julien-nc julien-nc merged commit 6ed14bb into master Dec 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/1975/hide-link-file-if-direct-editing branch December 2, 2021 14:43
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 2, 2021
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Dec 2, 2021

The backport to stable22 failed. Please do this backport manually.

@julien-nc julien-nc mentioned this pull request Dec 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@mejo- mejo- mejo- approved these changes

Assignees

No one assigned

Labels

3. to review bug Something isn't working format: markdown

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

"Link file" button is displayed in Android client

4 participants

@julien-nc @juliusknorr @mejo-