[stable22] Fix scss deprecated syntax #1993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/compile amend / |
Member
|
Pushed a commit as the package.json allowed using node 16 and then there is no prebuilt libsass available for that node version and the compile command fails with that. Remaining question is why the local build is different from the one in the Node CI / build action, but we can try to compare when the compile action commited the expected result. Let's see |
Member
|
/compile |
Member
|
At least CI is stable with that but the local build is still different even with the exact same node/npm versions. Not sure why though, the diff is rather odd with just some mapping hash changes it seems, using |
This was referenced Dec 7, 2021
julien-nc
force-pushed
the
fix/compiling/stable22
branch
from
4fe7982 to
2c734d2
Compare
Member
Author
|
/compile amend |
Signed-off-by: Julien Veyssier <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
fix/compiling/stable22
branch
from
2c734d2 to
836ecf1
Compare
mejo-
approved these changes
Dec 7, 2021
This was referenced Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the compilation fail in some contexts.