Azul/rebase stable22 fix 1677 menububble position #2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
#2020 to track the regression. |
danxuliu
approved these changes
Dec 20, 2021
Contributor
Author
|
The build failure is unrelated. Will fix that elsewhere. |
Add a `position: relative` to `content-wrapper` to fix misalignment of the menububble. The menububble has an absolute position which is calculated by tiptap based on the position of the highlighted text. It is styled with `left` and `bottom` attributes. These are relative to the position of the `.content-wrapper`. Signed-off-by: Azul <[email protected]>
For the rest of the text we keep the position above. Signed-off-by: Azul <[email protected]>
azul
force-pushed
the
azul/rebase-stable22-fix-1677-menububble-position
branch
from
3e5273a to
ab0f970
Compare
In rich workspaces scrolling still made the menu-bubble render at the wrong place. The element that the absolute position of the menu-bubble is relative to needs to grow with the text so tiptap can position the menu-bubble correctly. Now we also do not need the margin bottom anymore. Signed-off-by: Azul <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
azul
force-pushed
the
azul/rebase-stable22-fix-1677-menububble-position
branch
from
ab0f970 to
ffca863
Compare
delete-merged-branch
bot
deleted the
azul/rebase-stable22-fix-1677-menububble-position
branch
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports the fix as is in stable23 and master.
This fix broke the display of the heading menu (it's not showing above the files in rich workspaces anymore).
We'll furthermore always want to display the menu below the selected line on mobile so it's not overlaying with copy and paste menus.
Will need to fix this in another pr... but for now get stable22 into the state of current development.