Skip to content

[stable23] fix: cypress login with new session feature #2046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 2 commits into from
Jan 4, 2022
Merged

[stable23] fix: cypress login with new session feature #2046

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7d57e9
fix: cypress login with new session feature
azul Dec 30, 2021
17ddab7
cypress: inspect the viewer in one test
azul Dec 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
cypress: inspect the viewer in one test 
Open the test.md file once and then check all the things.

Signed-off-by: Azul <[email protected]>
  • Loading branch information
@azul @backportbot
azul authored and backportbot[bot] committed Jan 3, 2022
commit 17ddab7df008f9b148ce9df8144fd33cd0c8490e
43 changes: 18 additions & 25 deletions cypress/integration/viewer.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,39 +45,32 @@ describe('Open test.md in viewer', function() {

it('Open the viewer on file click', function() {
cy.openFile('test.md')
cy.get('#viewer').should('be.visible')
cy.get('#viewer .modal-title').should('contain', 'test.md')
cy.get('#viewer .modal-header button.action-item__menutoggle').should('be.visible')
cy.get('#viewer .modal-header button.header-close').should('be.visible')

cy.wait(2000)
cy.get('#viewer', { timeout: 4000 })
.should('be.visible')
cy.log('Inspect viewer')
const viewer = cy.get('#viewer')
viewer.should('be.visible')
.and('have.class', 'modal-mask')
.and('not.have.class', 'icon-loading')
})
viewer.get('.modal-title').should('contain', 'test.md')
viewer.get('.modal-header button.action-item__menutoggle')
.should('be.visible')

it('Has opened the file', function() {
cy.get('#viewer #editor .ProseMirror').should('contain', 'Hello world')
cy.get('#viewer #editor .ProseMirror h2').should('contain', 'Hello world')
})
cy.log('Inspect editor')
const editor = viewer.get('#editor .ProseMirror')
editor.should('contain', 'Hello world')
editor.get('h2').should('contain', 'Hello world')

cy.log('Inspect menubar')
const menubar = editor.get('.menubar .menubar-icons')
menubar.get('.icon-undo').should('be.visible')
menubar.get('.icon-bold').should('be.visible')

it('Shows the menu bar icons', function() {
// FIXME those checks are failing since the parent container is currently at 0x0 size
// due to the way we make the text app be a full screen viewer
// cy.get('#viewer-content #editor .menubar .menubar-icons .icon-undo').should('be.visible')
// cy.get('#viewer-content #editor .menubar .menubar-icons .icon-redo').should('be.visible')
// cy.get('#viewer-content #editor .menubar .menubar-icons .icon-bold').should('be.visible')
cy.screenshot()
})

it('Closes the editor', function() {
cy.get('.modal-header button.header-close').click()
cy.openFile('test.md')
cy.get('#viewer .modal-header button.header-close').click()
cy.get('#viewer').should('not.exist')
})

it('Take screenshot', function() {
// gif is impossible to match with existing screenshot
// just taking a screenshot to manually compare if needed
cy.screenshot()
})
})