Fix closing the editor modal in public folder view #2104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable23 |
Collaborator
|
/compile amend / |
max-nextcloud
approved these changes
Jan 17, 2022
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Looks good to me. Will trigger a recompilation of the js assets. Then this should be ready to go.
Signed-off-by: Julien Veyssier <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
fix/noid/public-editor-modal-mask-remains
branch
from
6d95718 to
8fc014d
Compare
delete-merged-branch
bot
deleted the
fix/noid/public-editor-modal-mask-remains
branch
max-nextcloud
added a commit
that referenced
this pull request
Jan 18, 2022
This is a regression tests for #2104. Signed-off-by: Max <[email protected]>
max-nextcloud
added a commit
that referenced
this pull request
Mar 2, 2022
This is a regression tests for #2104. Signed-off-by: Max <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the
closeevent emitted by the<PublicFilesEditor>component is not caught anywhere. Theactiveproperty of<PublicFilesEditor>never changes and the modal is not properly closed.This destroys the Vue instance rendering
<PublicFilesEditor>when thecloseevent is emitted.This needs to be backported at least in stable23.