[stable23] Use file.path to track EditorWrapper instances more accurately #2150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot-nextcloud
bot
requested review from
artonge,
julien-nc,
max-nextcloud and
mejo-
Member
|
/compile amend |
nextcloud-command
force-pushed
the
backport/2145/stable23
branch
from
aec59ab to
4e5682c
Compare
mejo-
approved these changes
Feb 3, 2022
artonge
approved these changes
Feb 3, 2022
max-nextcloud
previously requested changes
Feb 17, 2022
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Blocking since this may have unintended consequences.
Say i edit a file and you rename it in the meantime... What should happen? I think it's a feature and not a bug, that the editing keeps working and i now edit the file with the new name.
max-nextcloud
dismissed
their stale review
tried it and now it works better than before.
This fixes rich workspace loading when moving a Readme.md into a folder and navigating into that folder. The file.id stay the same, so no new components are created and RichWorkspace stays in an ready=false state because EditorWrapper never emit a new ready event. Signed-off-by: Louis Chemineau <[email protected]> Signed-off-by: Julien Veyssier <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
max-nextcloud
force-pushed
the
backport/2145/stable23
branch
from
4e5682c to
b44341f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #2145