Skip to content

Feature/114/tables #2235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-nextcloud merged 26 commits into from
Mar 31, 2022
Merged

Feature/114/tables #2235

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
4629457
feature: initial table support
max-nextcloud Mar 9, 2022
a62606c
refactor: render Markdown in table nodes
max-nextcloud Mar 10, 2022
759f8cb
fix: handling of various table formats
max-nextcloud Mar 14, 2022
c41a661
feature: add table button to create a table
max-nextcloud Mar 14, 2022
921080c
💄 (#114): add table css
Mar 14, 2022
39cf02c
fix: keep tables separate in markdown
max-nextcloud Mar 15, 2022
2443861
refactor: separate file for TableHeadRow
max-nextcloud Mar 15, 2022
15480e0
fix: use tableRole `row` for headerRow
max-nextcloud Mar 15, 2022
230dba7
fix: table layout to match prosemirror expectations
max-nextcloud Mar 16, 2022
df1deb6
fix: preserve td and th attributes
max-nextcloud Mar 16, 2022
7481eee
style: add border radius to table
max-nextcloud Mar 16, 2022
11ccb11
style: margin below a table to keep them separated
max-nextcloud Mar 16, 2022
fca037f
fix: make tab leave table on last cell.
max-nextcloud Mar 16, 2022
d626d24
enhance: move cursor down in table on enter
max-nextcloud Mar 17, 2022
932191e
ui: use table icon from material design
max-nextcloud Mar 17, 2022
5ea0628
feat: add and remove columns in tables
max-nextcloud Mar 21, 2022
3491ccb
ui: add actions for rows
max-nextcloud Mar 21, 2022
2e0440e
ui: translate table actions, new icons
max-nextcloud Mar 22, 2022
3bd2f3a
ui: reduce spacing in table headers
max-nextcloud Mar 22, 2022
0cd70c0
fix: disallow creating a table from within a table
max-nextcloud Mar 22, 2022
b1c27a4
ui: tweak tables
max-nextcloud Mar 22, 2022
9ebbe2e
make npm_package_name available
max-nextcloud Mar 23, 2022
08a9764
feature: button to remove table
max-nextcloud Mar 23, 2022
29d068e
ui: use primary-light color for hovered table row
max-nextcloud Mar 23, 2022
d7ae7e7
💄 (#114): add table css variables
Mar 30, 2022
52c36ba
build: compile js
max-nextcloud Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: disallow creating a table from within a table 
Signed-off-by: Max <[email protected]>
  • Loading branch information
@max-nextcloud
max-nextcloud committed Mar 31, 2022
commit 0cd70c0690a574259af5bea3cdc9878f876885bb
1 change: 1 addition & 0 deletions src/nodes/Table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ export default Table.extend({
return {
...this.parent(),
insertTable: () => ({ tr, dispatch, editor }) => {
if (isInTable(tr)) return false
const node = createTable(editor.schema, 3, 3, true)
if (dispatch) {
const offset = tr.selection.anchor + 1
Expand Down