build(deps-dev): bump @nextcloud/eslint-config from 7.0.2 to 8.0.0

[dependabot]

Bumps @nextcloud/eslint-config from 7.0.2 to 8.0.0.

Release notes

Sourced from @​nextcloud/eslint-config's releases.

v8.0.0

v8.0.0 (2022-04-20)

Full Changelog

Breaking:

• Require file extensions on import #292 (Pytal)

Dependency updates:

• Bump eslint from 8.7.0 to 8.8.0 #282 (dependabot[bot])
• Bump eslint from 8.8.0 to 8.9.0 #296 (dependabot[bot])

Changelog

Sourced from @​nextcloud/eslint-config's changelog.

v8.0.0 (2022-04-20)

Full Changelog

Breaking:

• Require file extensions on import #292 (Pytal)

Dependency updates:

• Bump eslint from 8.7.0 to 8.8.0 #282 (dependabot[bot])
• Bump eslint from 8.8.0 to 8.9.0 #296 (dependabot[bot])

Commits

• 2a23286 Merge pull request #337 from nextcloud/release/v8.0.0
• e13ab12 8.0.0
• 77455a5 Merge pull request #336 from nextcloud/dependabot/npm_and_yarn/eslint-plugin-...
• 3a24fce Bump eslint-plugin-jsdoc from 39.2.2 to 39.2.3
• 1bb0362 Merge pull request #335 from nextcloud/dependabot/npm_and_yarn/eslint-plugin-...
• 839c63a Bump eslint-plugin-jsdoc from 39.2.1 to 39.2.2
• b5d312f Merge pull request #333 from nextcloud/dependabot/npm_and_yarn/eslint-plugin-...
• c7af1d8 Bump eslint-plugin-jsdoc from 38.1.6 to 39.2.1
• 777562d Merge pull request #331 from nextcloud/dependabot/npm_and_yarn/eslint-8.13.0
• 2539ce6 Bump eslint from 8.12.0 to 8.13.0
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[max-nextcloud]

@dependabot rebase

[max-nextcloud]

fe37e99 adds all the @nextcloud/eslint-config peer dependencies as dev dependencies. We were missing eslint-plugin-jsdoc before which lead to failures of cypress tests.
Include all of the peer dependencies to prevent this in the future.

[vinicius73]

/compile

[max-nextcloud]

frankly... i have no idea why cypress is failing here.

The error was:

Error: Webpack Compilation Error
Failed to load plugin 'jsdoc' declared in '.eslintrc.js » @nextcloud/eslint-config': Unexpected token '?'
Referenced from: /home/runner/work/text/text/apps/text/node_modules/@nextcloud/eslint-config/index.js

Trace

    at handle (/home/runner/work/text/text/apps/text/node_modules/@cypress/webpack-preprocessor/dist/index.js:180:23)
    at finalCallback (/home/runner/work/text/text/apps/text/node_modules/webpack/lib/Compiler.js:441:32)
    at /home/runner/work/text/text/apps/text/node_modules/webpack/lib/Compiler.js:505:17
    at /home/runner/work/text/text/apps/text/node_modules/webpack/lib/HookWebpackError.js:68:3
    at Hook.eval [as callAsync] (eval at create (/home/runner/work/text/text/apps/text/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:4:1)
    at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/home/runner/work/text/text/apps/text/node_modules/tapable/lib/Hook.js:18:14)
    at Cache.storeBuildDependencies (/home/runner/work/text/text/apps/text/node_modules/webpack/lib/Cache.js:122:37)
    at /home/runner/work/text/text/apps/text/node_modules/webpack/lib/Compiler.js:501:19
    at Hook.eval [as callAsync] (eval at create (/home/runner/work/text/text/apps/text/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:4:1)
    at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/home/runner/work/text/text/apps/text/node_modules/tapable/lib/Hook.js:18:14)
    at /home/runner/work/text/text/apps/text/node_modules/webpack/lib/Compiler.js:498:23
    at Compiler.emitRecords (/home/runner/work/text/text/apps/text/node_modules/webpack/lib/Compiler.js:919:5)
    at /home/runner/work/text/text/apps/text/node_modules/webpack/lib/Compiler.js:490:11
    at /home/runner/work/text/text/apps/text/node_modules/webpack/lib/Compiler.js:885:14
    at Hook.eval [as callAsync] (eval at create (/home/runner/work/text/text/apps/text/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:4:1)
    at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/home/runner/work/text/text/apps/text/node_modules/tapable/lib/Hook.js:18:14)
    at /home/runner/work/text/text/apps/text/node_modules/webpack/lib/Compiler.js:882:27
    at /home/runner/work/text/text/apps/text/node_modules/neo-async/async.js:2818:7
    at done (/home/runner/work/text/text/apps/text/node_modules/neo-async/async.js:3522:9)
    at Hook.eval [as callAsync] (eval at create (/home/runner/work/text/text/apps/text/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:4:1)
    at /home/runner/work/text/text/apps/text/node_modules/webpack/lib/Compiler.js:736:33
    at /home/runner/work/text/text/apps/text/node_modules/graceful-fs/graceful-fs.js:143:16
    at /home/runner/.cache/Cypress/9.6.0/Cypress/resources/app/node_modules/graceful-fs/graceful-fs.js:143:16
    at /home/runner/.cache/Cypress/9.6.0/Cypress/resources/app/node_modules/graceful-fs/graceful-fs.js:61:14
    at FSReqCallback.oncomplete (fs.js:156:23)

This occurred while Cypress was compiling and bundling your test code. This is usually caused by:

• A missing file or dependency
• A syntax error in the file or one of its dependencies

Fix the error in your code and re-run your tests.

[vinicius73]

frankly... i have no idea why cypress is failing here.

I have an idea, I will send a fix in this PR

[vinicius73]

/compile

[max-nextcloud]

In #2358 I was able to narrow this down to nextcloud-libraries/eslint-config@c7af1d8
nextcloud/eslint before this commit runs the cypress test fine. Afterwards it starts failing. Trying to narrow it down further to the eslint-plugin-jsdoc change that started breaking things - no idea if this will be useful - but worth a try anyway.

It's also failing with nextcloud-libraries/eslint-config@6ebdcf4 (eslint-plugin-jsdoc 39.0.1 )
So the breaking change must be somewhere in here: gajus/eslint-plugin-jsdoc@v38.1.6...v39.0.1

[vinicius73]

Cypress is using Node v12

[max-nextcloud]

Cypress is using Node v12

Excellent catch 🎣 - thanks for looking into this. That also explains why it would run for me locally.