Skip to content

Conversation

@max-nextcloud
Copy link
Collaborator

They take 10 minutes to setup nextcloud
and block available CI runners.

This is particularly wasteful with javascript dependency updates.
Dependabot will rebase the pending updates
upon every push to the underlying branch.

Signed-off-by: Max [email protected]

  • Resolves: #
  • Target version: master

Summary

@max-nextcloud max-nextcloud force-pushed the ci/only-run-phpunit-when-php-changed branch from e48ad9e to 8689b18 Compare May 1, 2022 03:37
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point 👍

They take 10 minutes to setup nextcloud
and block available CI runners.

This is particularly wasteful with javascript dependency updates.
Dependabot will rebase the pending updates
upon every push to the underlying branch.

Signed-off-by: Max <[email protected]>
@juliusknorr juliusknorr force-pushed the ci/only-run-phpunit-when-php-changed branch from 8689b18 to 6e2ac76 Compare May 2, 2022 11:21
@max-nextcloud max-nextcloud merged commit edf6e48 into master May 2, 2022
@delete-merged-branch delete-merged-branch bot deleted the ci/only-run-phpunit-when-php-changed branch May 2, 2022 13:03
@juliusknorr
Copy link
Member

/backport to stable24

@juliusknorr
Copy link
Member

/backport to stable23

@juliusknorr
Copy link
Member

/backport to stable22

@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@max-nextcloud
Copy link
Collaborator Author

@juliushaertl frankly I think the backports do not matter so much. Most PR's run against master and master is getting updated frequently so that dependabot rebases also happen quite often. So having this in master will already reduce ci times significantly.
It might be good for consistency to apply it to older branches - but i don't think it's really needed. I'm thinking about doing the same for nextcloud/server - i think that would save more CI minutes with a comparable effort to backporting it in text.

@max-nextcloud
Copy link
Collaborator Author

Looks like i've been wrong about stable24. Tiptap has a lot of small packages in a monorepo that all get bumped at once. And stable24 is still up to date with them. So we get a lot of stable24 updates for tiptap. I'll start a backport of this to stable24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported successfully backported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants