fix: only show delete image button when editing #2359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-nextcloud
force-pushed
the
fix/hide-image-trash-in-readonly
branch
from
81f45db to
7d92f58
Compare
Collaborator
Author
|
/compile |
vinicius73
reviewed
May 4, 2022
src/tests/nodes/ImageView.spec.js
Outdated
| const factory = attrs => { | ||
| const propsData = { | ||
| extension: { options: {currentDirectory: '/current'} }, | ||
| editor: { isEditable: true }, |
Member
There was a problem hiding this comment.
Do we have a test case for when this value is false?
Collaborator
Author
There was a problem hiding this comment.
We have now. :)
max-nextcloud
force-pushed
the
fix/hide-image-trash-in-readonly
branch
from
b08ea11 to
4564b00
Compare
max-nextcloud
force-pushed
the
fix/hide-image-trash-in-readonly
branch
2 times, most recently
from
4c6c536 to
9c8026f
Compare
Collaborator
Author
|
/compile amend / |
nextcloud-command
force-pushed
the
fix/hide-image-trash-in-readonly
branch
from
9c8026f to
3b22370
Compare
Also test for it being shown and triggering the deleteNode when editing. Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
fix/hide-image-trash-in-readonly
branch
from
3b22370 to
158ab34
Compare
Collaborator
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Collaborator
Author
|
/backport to stable24 |
|
The backport to stable24 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Max [email protected]
Summary
We used to show the delete image button even in read only views - such as a public share without editing permission.
Only show it when people are actually allowed to remove the image.