Fix non-working hard line breaks #2455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable24 |
Member
Author
|
/backport d215431 to stable23 |
Member
Author
|
/backport d215431 to stable22 |
vinicius73
approved these changes
May 27, 2022
Member
|
@juliushaertl have we a way to create a regression test for this behavior? |
Collaborator
|
Thanks for catching this. Looks good. |
max-nextcloud
requested changes
May 28, 2022
juliusknorr
force-pushed
the
bugfix/hard-break
branch
from
b80efd0 to
9154a36
Compare
Member
Author
|
/compile amend / |
nextcloud-command
force-pushed
the
bugfix/hard-break
branch
from
9154a36 to
4e4de45
Compare
Member
Author
|
/rebase |
juliusknorr
force-pushed
the
bugfix/hard-break
branch
from
4e4de45 to
f05f53c
Compare
Member
Author
|
/compile |
max-nextcloud
approved these changes
Jun 7, 2022
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
…wn transformation Signed-off-by: Julius Härtl <[email protected]>
max-nextcloud
force-pushed
the
bugfix/hard-break
branch
from
4f2abd9 to
efb27a5
Compare
Collaborator
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
|
The backport to stable24 failed. Please do this backport manually. |
|
The backport to stable23 failed. Please do this backport manually. |
|
The backport to stable22 failed. Please do this backport manually. |
Member
Author
|
Manual backport to 23/22 might need a bit more work to make it work with tiptap v1 |
Member
Author
|
Leaving for backport for the next maintenance releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like the hard break plugin got lost during migration to tiptap v2 (https://github.com/nextcloud/text/blob/stable23/src/EditorFactory.js#L73)
Now the first commit restores the previous behaviour to support hard breaks in text. The second transforms the output markdown to use double space instead of a backslash at the line end to indicate the hard break, which is less intrusive in the plain markdown. Both are allowed according to https://spec.commonmark.org/0.30/#hard-line-breaks
The backslash is the default format provided by prosemirror-markdown:
https://github.com/ProseMirror/prosemirror-markdown/blob/master/src/to_markdown.ts#L107-L113