Skip to content

Feature: Add page anchors and inter page links #2464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
susnux wants to merge 5 commits into from
Closed

Feature: Add page anchors and inter page links #2464

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
68eb75b
Feature: Add IDs to headings to allow inter-page links
susnux May 30, 2022
ded3284
Add visibile and clickable links for the page anchors
susnux May 30, 2022
76f1605
Fix handle inter-page links
susnux May 30, 2022
109a243
Merge remote-tracking branch 'origin/master' into feature/inter-page
Jun 1, 2022
cdb01d9
🩹 (#2173): prevent anchors when is rich workspace
Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix handle inter-page links 
Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux
susnux committed May 30, 2022
commit 76f16055478c98e311583f11797464ae0b2c436b
6 changes: 6 additions & 0 deletions src/plugins/link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@ const clickHandler = ({ editor }) => {
event.stopPropagation()

if (event.button === 0 && !event.ctrlKey && htmlHref.startsWith(window.location.origin)) {
if (window.location.href.split('#')[0] === htmlHref.split('#')[0]) {
// Inter-page link, so move to location
window.open(htmlHref, '_self')
return
}

const query = OC.parseQueryString(htmlHref)
const fragment = OC.parseQueryString(htmlHref.split('#').pop())
if (query.dir && fragment.relPath) {
Expand Down