Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr requested review from a team, julien-nc and max-nextcloud and removed request for a team June 3, 2022 12:27
@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Jun 3, 2022
@juliusknorr juliusknorr requested a review from jancborchardt June 3, 2022 12:27
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@juliusknorr juliusknorr force-pushed the bugfix/noid/gener-neutral branch from 25d93c4 to 839e4d7 Compare June 8, 2022 07:56
<Popover class="session-list" placement="top">
<button slot="trigger"
v-tooltip.bottom="t('text', 'Participants')"
v-tooltip.bottom="t('text', 'Active people')"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd even just say "People" for simplicity, also cause "Active" might not be true if they are afk for a few minutes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinion there, my initial thought was that it would make it a bit more obvious on what people you actually see there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok then let’s just go with it like this, we can always adjust :)

@juliusknorr juliusknorr force-pushed the bugfix/noid/gener-neutral branch from 839e4d7 to 4e19f0c Compare June 9, 2022 19:40
@juliusknorr juliusknorr added this to the Nextcloud 25 milestone Jun 9, 2022
@juliusknorr juliusknorr force-pushed the bugfix/noid/gener-neutral branch from 4e19f0c to a2f15f1 Compare June 10, 2022 09:16
@juliusknorr
Copy link
Member Author

/compile

Signed-off-by: nextcloud-command <[email protected]>
@juliusknorr juliusknorr merged commit 7ec0cae into master Jun 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the bugfix/noid/gener-neutral branch June 10, 2022 10:07
@max-nextcloud
Copy link
Collaborator

/backport a2f15f1 to stable24

@max-nextcloud
Copy link
Collaborator

/backport a2f15f1 to stable23

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants