Avoid loading the image before the node view #2496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
/rebase |
nextcloud-command
force-pushed
the
bugfix/double-load
branch
from
acdd1c9 to
7c5e719
Compare
Member
|
/compile amend |
Signed-off-by: Julius Härtl <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
bugfix/double-load
branch
from
7c5e719 to
0752577
Compare
vinicius73
approved these changes
Jun 30, 2022
Collaborator
|
/backport to stable24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found when testing #2466
Before this change there was one request for each image initiated by the prose mirror setup of the node, even before our custom image view was initialised. Since the url /apps/files/PATH/TO/IMAGE.jpg is not a valid route this always failed and got redirected to the index page.
Since we have a custom node view we can just return an empty img tag in the renderHTML function without the src to avoid that.