Feature: Add page anchors and inter page links #2520
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinicius73
reviewed
Jun 17, 2022
Contributor
Author
|
Rebased onto the current master |
juliusknorr
requested review from
a team,
Raudius,
juliusknorr,
max-nextcloud and
vinicius73
and removed request for
a team and
Raudius
Merged
Implements the anchors needed for inter-page links, closes #2173. IDs are generated using a similar slugify function github and gitlab use. For initial content markdownit-anchor is used. Signed-off-by: Ferdinand Thiessen <[email protected]>
Using ProseMirror view decorations to display visible anchor links on headings. Fix handling of inter-page links Scroll to selected header when clicking on the anchor link Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Contributor
Author
|
Closing this in favor of #2841 (As most parts are already resolved by the outline view, also this PR's origin is my personal fork so CI tasks are not possible) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Lightweight version of #2464, see that request for full discussion.
This implements the anchors needed for inter-page links as well as clickable
anchor links.