Skip to content

Fix/dav #2608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-nextcloud merged 6 commits into from
Jul 6, 2022
Merged

Fix/dav #2608

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
82b1234
Revert "fix: DAV only return workspace properties if they are set"
CarlSchwan Jun 21, 2022
4f5a37d
Assume that the default depth is 1 in DAV
CarlSchwan Jun 21, 2022
63bbd4a
test: propfind extension for workspaces
max-nextcloud Jun 22, 2022
741d952
fix: bring back the share owner handling and workspace file id
max-nextcloud Jun 22, 2022
bfe8a13
fix: always handle workspace properties
max-nextcloud Jun 22, 2022
940e1b5
Avoid duplicate queries and limit depth by default to 0
juliusknorr Jul 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Assume that the default depth is 1 in DAV 
Otherwise if the Depth header is ommited, the workspace information
won't be display at all.

Signed-off-by: Carl Schwan <[email protected]>
  • Loading branch information
@CarlSchwan @max-nextcloud
CarlSchwan authored and max-nextcloud committed Jul 6, 2022
commit 4f5a37dcbddaf79ae7416860f9c9334b17936175
2 changes: 1 addition & 1 deletion lib/DAV/WorkspacePlugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ public function propFind(PropFind $propFind, INode $node) {
}

// Only return the property for the parent node and ignore it for further in depth nodes
if ($propFind->getDepth() === $this->server->getHTTPDepth()) {
if ($propFind->getDepth() === $this->server->getHTTPDepth(1)) {
$propFind->handle(self::WORKSPACE_PROPERTY, function () use ($node) {
/** @var Folder[] $nodes */
$nodes = $this->rootFolder->getUserFolder($this->userId)->getById($node->getId());
Expand Down