Update toolbar button style #2627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
Contributor
Author
|
Here are videos on desktop and mobile: Screencast.from.30-06-2022.23_32_23.webmScreencast.from.30-06-2022.23_34_56.webm |
luka-nextcloud
force-pushed
the
feature/2607-toolbar-button-style
branch
from
911b116 to
0b42920
Compare
Member
|
/rebase |
nextcloud-command
force-pushed
the
feature/2607-toolbar-button-style
branch
from
0b42920 to
85e5351
Compare
Member
|
Looks nice! Just what's the blue border around the textarea, that shouldn't be there. :) |
Member
I guess it is related to nextcloud/server#31584 |
Member
|
/compile amend |
nextcloud-command
force-pushed
the
feature/2607-toolbar-button-style
branch
from
85e5351 to
d54a8b7
Compare
vinicius73
approved these changes
Jun 30, 2022
vinicius73
added
enhancement
vinicius73
reviewed
Jun 30, 2022
src/components/Menu/ActionEntry.scss
Outdated
| background-color: var(--color-primary-light); | ||
| border-radius: 50%; | ||
| svg { | ||
| fill: var(--color-primary) !important; |
Member
There was a problem hiding this comment.
Is it possible to avoid !important here and in line 75?
Contributor
Author
There was a problem hiding this comment.
I tried to get rid of it but we need it in those lines.
Member
There was a problem hiding this comment.
Maybe setting color: var(--color-primary); on the parent could work as the svg should use currentColor?
Contributor
Author
There was a problem hiding this comment.
Unfortunately, it doesn't work.
Collaborator
|
/rebase |
max-nextcloud
force-pushed
the
feature/2607-toolbar-button-style
branch
from
d54a8b7 to
d82cdac
Compare
Collaborator
|
/compile |
luka-nextcloud
force-pushed
the
feature/2607-toolbar-button-style
branch
from
640a465 to
3f25d10
Compare
Contributor
Author
|
/rebase |
Signed-off-by: Luka Trovic <[email protected]>
nextcloud-command
force-pushed
the
feature/2607-toolbar-button-style
branch
from
3f25d10 to
37fef5d
Compare
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luka Trovic [email protected]
Summary