Link handling fixes #2668
Merged
Link handling fixes #2668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/compile amend |
nextcloud-command
force-pushed
the
fix/link_handling
branch
from
139043f to
0aedd20
Compare
vinicius73
approved these changes
Jul 4, 2022
Collaborator
|
/rebase |
We use a prosemirror plugin with the `handleClick` handler to handle clicking on links, so we don't want the default browser link handling to happen. See earlier commit 5bf15b4 for reference. Signed-off-by: Jonas <[email protected]>
We only want our custom link handlers (either the default from Text app or a further customized one, e.g. from Collectives app) to happen if the first mouse button is used, Ctrl key is not pressed and the link points to a local link. Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
fix/link_handling
branch
from
0aedd20 to
eedb91e
Compare
max-nextcloud
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.