Adapt to latest changes in OCP\Color #2706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I don't understand Psalm complaints... |
Member
|
Psalm uses the meta package to test against the OCP namespaces and this has not been updated yet: https://github.com/ChristophWurst/nextcloud_composer (should auto-resolve after the nightly bump) |
juliusknorr
reviewed
Jul 11, 2022
lib/Service/SessionService.php
Outdated
| $uniqueGuestId = !empty($guestName) ? $guestName : $this->secureRandom->generate(12); | ||
| $color = $this->avatarManager->getGuestAvatar($uniqueGuestId)->avatarBackgroundColor($uniqueGuestId); | ||
| return sprintf("#%02x%02x%02x", $color->r, $color->g, $color->b); | ||
| return sprintf("#%02x%02x%02x", $color->red(), $color->green(), $color->blue()); |
Member
There was a problem hiding this comment.
As now available with the new API:
Suggested change
| return sprintf("#%02x%02x%02x", $color->red(), $color->green(), $color->blue()); | |
| return $color->name(); |
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
fix/2705/new-color-public-api
branch
from
e4324a0 to
9d80897
Compare
max-nextcloud
approved these changes
Jul 12, 2022
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Tried this locally and it fixed the color issue for me. I have no idea about the static analysis failure though.
Member
|
Retriggered static analysis since ChristophWurst/nextcloud_composer@7367ca1 is there after the nightly auto update. |
juliusknorr
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #2705
The r,g,b attributes are now private.