Skip to content

Some backend cleanup #2719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vinicius73 merged 6 commits into from
Jul 18, 2022
Merged

Some backend cleanup #2719

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d27e2e0
Strict types and move Exceptions to dedicated namespace
juliusknorr Jul 14, 2022
7739cab
Move to LoggerInterface
juliusknorr Jul 14, 2022
8b3a4d2
More typing and remove unused property
juliusknorr Jul 14, 2022
c00ad0a
More typing
juliusknorr Jul 15, 2022
f8b1225
Fix some psalm issues with Entities
juliusknorr Jul 15, 2022
3d58268
🩹 (#2719): fix interface typing
Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
More typing 
Signed-off-by: Julius Härtl <[email protected]>
  • Loading branch information
@juliusknorr
juliusknorr authored and Vinicius Reis committed Jul 18, 2022
commit c00ad0aa5a82563242d73326a0ed42946ed9a08d
11 changes: 3 additions & 8 deletions lib/Controller/PublicSessionController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,9 @@

class PublicSessionController extends PublicShareController {

/** @var ShareManager */
private $shareManager;

/** @var IShare */
private $share;

/** @var ApiService */
private $apiService;
private ShareManager $shareManager;
private ?IShare $share;
private ApiService $apiService;

public function __construct(string $appName, IRequest $request, ISession $session, ShareManager $shareManager, ApiService $apiService) {
parent::__construct($appName, $request, $session);
Expand Down
6 changes: 1 addition & 5 deletions lib/Controller/SessionController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,7 @@
use OCP\IRequest;

class SessionController extends Controller {

/**
* @var ApiService
*/
private $apiService;
private ApiService $apiService;

public function __construct(string $appName, IRequest $request, ApiService $apiService) {
parent::__construct($appName, $request);
Expand Down
6 changes: 2 additions & 4 deletions lib/Controller/SettingsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,8 @@

class SettingsController extends Controller {

/**
* @var IConfig
*/
private $config;
private IConfig $config;
private ?string $userId;

public const ACCEPTED_KEYS = [
'workspace_enabled'
Expand Down
23 changes: 6 additions & 17 deletions lib/Controller/WorkspaceController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,23 +70,12 @@

class WorkspaceController extends OCSController {

/** @var IRootFolder */
private $rootFolder;

/** @var IManager */
private $shareManager;

/** @var WorkspaceService */
private $workspaceService;

/** @var string|null */
private $userId;

/** @var IDirectEditingManager */
private $directEditingManager;

/** @var IURLGenerator */
private $urlGenerator;
private IRootFolder $rootFolder;
private IManager $shareManager;
private WorkspaceService $workspaceService;
private ?string $userId;
private IDirectEditingManager $directEditingManager;
private IURLGenerator $urlGenerator;

/** @var IEventDispatcher */
private $eventDispatcher;
Expand Down