Skip to content

Replace id to class for files app #2745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PVince81 merged 1 commit into from
Jul 26, 2022
Merged

Replace id to class for files app #2745

PVince81 merged 1 commit into from
Jul 26, 2022

Conversation

@PVince81
Copy link
Member

@PVince81 PVince81 commented Jul 22, 2022 •
edited
Loading

For nextcloud/server#33320

  • revert workflow change once server/master is merged

@PVince81 PVince81 self-assigned this Jul 22, 2022
@PVince81 PVince81 mentioned this pull request Jul 22, 2022
Merged
22 tasks
@PVince81 PVince81 changed the title Bugfix/noid/remote files duplicate dom ids Replace id to class for files app Jul 22, 2022
@juliusknorr
Copy link
Member

juliusknorr commented Jul 25, 2022

Cypress tests should cover most of the files app integration bits, so this looks reasonable to do from the text app side 👍

@PVince81 PVince81 force-pushed the bugfix/noid/remote-files-duplicate-dom-ids branch from bf72df6 to ec7cdd2 Compare July 26, 2022 07:51
@PVince81 PVince81 force-pushed the bugfix/noid/remote-files-duplicate-dom-ids branch from ec7cdd2 to cd3e88e Compare July 26, 2022 08:40
@PVince81
Copy link
Member Author

PVince81 commented Jul 26, 2022

conflict solved

@PVince81
Copy link
Member Author

PVince81 commented Jul 26, 2022

all green

@PVince81 PVince81 force-pushed the bugfix/noid/remote-files-duplicate-dom-ids branch from cd3e88e to 259d554 Compare July 26, 2022 10:21
@PVince81 PVince81 marked this pull request as ready for review July 26, 2022 10:22
@PVince81
Copy link
Member Author

PVince81 commented Jul 26, 2022

I assume your thumbs up was intended to be an approval @juliushaertl

@PVince81 PVince81 merged commit e89419f into master Jul 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the bugfix/noid/remote-files-duplicate-dom-ids branch July 26, 2022 10:37
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@PVince81 PVince81

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PVince81 @juliusknorr