Skip to content

Add user mentions feature #2748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 16 commits into from
Aug 25, 2022
Merged

Add user mentions feature #2748

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
5e0d9f4
feat: add user mentions feature
luka-nextcloud Jul 23, 2022
bce30b8
feat: enhance user mention ui
luka-nextcloud Aug 3, 2022
edca2da
fix: solve markdown-it-mentions issues
luka-nextcloud Aug 5, 2022
a84270b
Fix linting
juliusknorr Aug 14, 2022
b238bde
Use vue component for the rendering
juliusknorr Aug 14, 2022
82288c4
Cleanup old html rendering
juliusknorr Aug 14, 2022
769ddf7
Fix keyboard navigation
juliusknorr Aug 14, 2022
b7f3f39
Fix editor opening when empty @ symbol is present
juliusknorr Aug 14, 2022
e15dc93
feat: display correct username and use ISearch to search users
luka-nextcloud Aug 23, 2022
c7af329
Fix parsing of HTML for the mention
juliusknorr Aug 24, 2022
890e615
fix: feedback
luka-nextcloud Aug 24, 2022
df441b7
Add stub for psalm
juliusknorr Aug 25, 2022
2e3c92a
Implement notification backend for mentions
juliusknorr Aug 25, 2022
768208d
Emit notification on adding a mention
juliusknorr Aug 25, 2022
9d5e85f
Compile assets
nextcloud-command Aug 25, 2022
c56493a
Mock additional methods of @nextcloud/auth during tests
juliusknorr Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix editor opening when empty @ symbol is present 
Signed-off-by: Julius Härtl <[email protected]>
  • Loading branch information
@juliusknorr
juliusknorr committed Aug 25, 2022
commit b7f3f3927b2c7d8a1d1e5693695fe22d93bafcc3
9 changes: 8 additions & 1 deletion src/components/Mention/suggestion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export default {
onUpdate(props) {
component.updateProps(props)

if (!props.clientRect) {
if (!props.clientRect || !popup) {
return
}

Expand All @@ -60,6 +60,10 @@ export default {
},

onKeyDown(props) {
if (!popup) {
return
}

if (props.event.key === 'Escape') {
popup[0].hide()

Expand All @@ -70,6 +74,9 @@ export default {
},

onExit() {
if (!popup) {
return
}
popup[0].destroy()
component.destroy()
},
Expand Down