-
Notifications
You must be signed in to change notification settings - Fork 109
Only autolink URLs containing protocol #2754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Raudius
commented
Jul 25, 2022
- Resolves: Feature request: Autolink feature should be optional #2723
- Target version: master
vinicius73
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM;
But tests should be updated.
https://github.com/nextcloud/text/runs/7501209373?check_suite_focus=true
text/cypress/e2e/links.spec.js
Lines 43 to 55 in 0b8750d
| it('whithout protocol', () => { | |
| cy.getContent() | |
| .type('google.com') | |
| cy.getContent() | |
| .find('a[href*="google.com"]') | |
| .click({ force: true }) | |
| cy.get('@winOpen') | |
| .should('have.been.calledOnce') | |
| .should('have.been.calledWith', 'http://google.com/') | |
| }) | |
| }) |
|
I guess restricting autolink to http(s) is fine, so lgtm after fixing the tests. |
86819a9 to
b2a4705
Compare
140cbea to
7ccc6c8
Compare
|
/compile amend |
7ccc6c8 to
ccf6f09
Compare
Signed-off-by: Raul <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
ccf6f09 to
32f0d22
Compare