[stable24] cleanup: wait statements - rely on promises instead #2755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a command returns a promise cypress will wait for that promise before proceeding with the next commands. Since 0162bb0 we return the promises from most commands. The explicit calls to cy.intercept and cy.wait are not needed anymore. Signed-off-by: Max <[email protected]>
backportbot-nextcloud
bot
requested review from
julien-nc,
max-nextcloud,
mejo- and
vinicius73
Collaborator
|
this seemed like a good idea when i added the backport request... but i think it would require backporting the commit that made the cypress commands return promisses and seems quite a bit of effort for little in return so i'll close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #2660