Do not try to get a displayname for guests #2849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
bugfix/noid-displayname-cache-public
branch
3 times, most recently
from
151ea6d to
d85ae8a
Compare
Collaborator
|
cypress tests are still failing but now they are exposing a different issue. Somehow there's no menubar and the editor is in a funny state when loaded from the share token. I have not been able to reproduce this outside of cypress yet though. |
Collaborator
|
Looks like the editable share doesn't do what i thought it does. May have to turn this into two requests or so. |
max-nextcloud
force-pushed
the
bugfix/noid-displayname-cache-public
branch
from
d85ae8a to
12410fb
Compare
Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
bugfix/noid-displayname-cache-public
branch
from
12410fb to
f3d2383
Compare
max-nextcloud
approved these changes
Aug 31, 2022
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Fixes the issue i ran into when trying to fix the cypress tests.
delete-merged-branch
bot
deleted the
bugfix/noid-displayname-cache-public
branch
Member
Author
|
Awesome, thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Julius Härtl [email protected]
Summary