Skip to content

Conversation

@vinicius73
Copy link
Member

No description provided.

@vinicius73 vinicius73 added tests If you write them we ♥ you 3. to review bug: regression labels Sep 2, 2022
@vinicius73 vinicius73 added this to the Nextcloud 25 milestone Sep 2, 2022
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working on this.
The approach looks good. I have some comments on the test.

Signed-off-by: Vinicius Reis <[email protected]>
@vinicius73 vinicius73 force-pushed the fix/noid/fix-sharing-folder branch from a662a3a to 68ebbc3 Compare September 3, 2022 15:27
@vinicius73
Copy link
Member Author

I have some comments on the test.

Thanks!
I've changed the test.

Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments. Looks great now!

@max-nextcloud
Copy link
Collaborator

/compile

Signed-off-by: nextcloud-command <[email protected]>
@vinicius73 vinicius73 merged commit 42afe60 into master Sep 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/noid/fix-sharing-folder branch September 4, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review tests If you write them we ♥ you

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants