Use @nextcloud/logger for all frontend logging
#2866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/compile amend |
nextcloud-command
force-pushed
the
feat/logger
branch
from
2935df6 to
da4aae5
Compare
Contributor
Author
|
/compile amend |
nextcloud-command
force-pushed
the
feat/logger
branch
from
a2c8d3e to
7907481
Compare
max-nextcloud
approved these changes
Sep 13, 2022
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
code looks good. Should not have any impact on behavior other than going through the @nextcloud/logger interface instead of console.*.
max-nextcloud
force-pushed
the
feat/logger
branch
2 times, most recently
from
86638b6 to
48c7ab8
Compare
Collaborator
|
/compile |
max-nextcloud
force-pushed
the
feat/logger
branch
from
48c7ab8 to
fbbf8cd
Compare
Collaborator
|
/compile |
The nextcloud logger take account for the configured logging level, so only messages the user / administrator wants are logged. This fixes #2846 (no debug messages are logged if not configured). Signed-off-by: Ferdinand Thiessen <[email protected]>
max-nextcloud
force-pushed
the
feat/logger
branch
from
fbbf8cd to
81d7af7
Compare
Collaborator
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The nextcloud logger take account for the configured logging level,
so only messages the user / administrator wants are logged.
This fixes #2846 (no debug messages are logged if not configured).