fix: update link menububble on editor updates #2872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the menububble always shows the correct entries. The menububble shows different buttons if the selected text is a link. However its content often became out of sync with the editor: * when new text was selected the bubble was still cached * when the selection stayed active but was expanded / shrinked the menu bubble also stayed the same * when someone else editing the same page changed the current selection into a link Recompute the menububbles `active` data on every editor change. The code used for this is mostly taken from the menu bars mechanism for the same purpose. See updateState in src/components/Menu/BaseActionEntry.js. Signed-off-by: Max <[email protected]>
Collaborator
Author
|
/compile |
Collaborator
Author
|
/backport to stable24 |
Signed-off-by: nextcloud-command <[email protected]>
max-nextcloud
commented
Sep 8, 2022
mejo-
approved these changes
Sep 8, 2022
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Thanks a lot, works nicely. I really like the approach with listening to changes from the editor.
|
The backport to stable24 failed. Please do this backport manually. |
Collaborator
Author
|
/backport 7bd2e54 to stable24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure the menububble always shows the correct entries.
The menububble shows different buttons if the selected text is a link. However its content often became out of sync with the editor:
Recompute the menububbles
activedata on every editor change.The code used for this is mostly taken from the menu bars mechanism for the same purpose.
See updateState in src/components/Menu/BaseActionEntry.js.