fix: add primary attribute for current user #2878
Merged
+32
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
The approach looks good.
ESLint has some complains as can be seen in the Files changed tab.
Other than that seems good to go.
vinicius73
reviewed
Sep 9, 2022
luka-nextcloud
force-pushed
the
bug/use-primary-attr-for-current-user-mention
branch
from
1236681 to
a1d9461
Compare
Contributor
Author
|
@max-nextcloud @vinicius73 Please check again. |
vinicius73
approved these changes
Sep 12, 2022
Member
|
/rebase |
Signed-off-by: Luka Trovic <[email protected]>
nextcloud-command
force-pushed
the
bug/use-primary-attr-for-current-user-mention
branch
from
a1d9461 to
640a1e1
Compare
Member
|
/compile |
mejo-
force-pushed
the
bug/use-primary-attr-for-current-user-mention
branch
from
6a6c456 to
1b1b77a
Compare
Member
|
I added a commit to fix the (unrelated) eslint warning introduced by #2867. |
Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
bug/use-primary-attr-for-current-user-mention
branch
from
1b1b77a to
18a0598
Compare
Member
|
/compile amend |
Signed-off-by: nextcloud-command <[email protected]> Signed-off-by: Jonas <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
bug/use-primary-attr-for-current-user-mention
branch
from
18a0598 to
7f883b1
Compare
mejo-
approved these changes
Sep 13, 2022
delete-merged-branch
bot
deleted the
bug/use-primary-attr-for-current-user-mention
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luka Trovic [email protected]
Summary