Skip to content

[stable24] Make it possible to insert heif/heic images #2975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 2 commits into from
Sep 26, 2022
Merged

[stable24] Make it possible to insert heif/heic images #2975

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b38d87f
make it possible to insert heif/heic images
Sep 20, 2022
1af6cb4
Compile assets
nextcloud-command Sep 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
make it possible to insert heif/heic images 
Signed-off-by: Julien Veyssier <[email protected]>
  • Loading branch information
Julien Veyssier committed Sep 25, 2022
commit b38d87ff11529bfe34db2db3b80a070ee6581f6f
2 changes: 2 additions & 0 deletions lib/Controller/ImageController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ class ImageController extends Controller {
'image/bmp',
'image/svg+xml',
'image/webp',
'image/heic',
'image/heif',
];

/**
Expand Down
2 changes: 2 additions & 0 deletions src/components/EditorWrapper.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,8 @@ const IMAGE_MIMES = [
'image/bmp',
'image/svg+xml',
'image/webp',
'image/heic',
'image/heif',
]

export default {
Expand Down
2 changes: 1 addition & 1 deletion src/components/MenuBar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<div class="menubar" :class="{ 'show': isVisible, 'autohide': autohide }">
<input ref="imageFileInput"
type="file"
accept="image/*"
accept="image/*, image/heic, image/heif"
Copy link
Member

@vinicius73 vinicius73 Sep 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it is necessary?

Copy link
Member Author

@julien-nc julien-nc Sep 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why but explicit heic/heif mime types have to be added in the <input>.
They are not shown with image/*.

aria-hidden="true"
class="hidden-visually"
:multiple="true"
Expand Down