Skip to content

Fix: menubar throws errors on master focus trap too much recursion #3066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vinicius73 merged 4 commits into from
Sep 29, 2022
Merged

Fix: menubar throws errors on master focus trap too much recursion #3066

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17c2da2
🐛 (#2842): use menu bar as container for emoji and list actions
Sep 27, 2022
ded2e2c
🐛 fix emoji picker event
Sep 28, 2022
e2b2dee
✏️ (#2842): change container of ActionAttachmentUpload
Sep 28, 2022
e64f0fe
Compile assets
nextcloud-command Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
✏️ (#2842): change container of ActionAttachmentUpload 
Signed-off-by: Vinicius Reis <[email protected]>
  • Loading branch information
@vinicius73
Vinicius Reis authored and vinicius73 committed Sep 29, 2022
commit e2b2dee6b063a9a1f253d9e348e2679a6915a7f0
3 changes: 3 additions & 0 deletions src/components/Menu/ActionAttachmentUpload.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
:data-text-action-entry="actionEntry.key"
:title="actionEntry.label"
:aria-label="actionEntry.label"
:container="menuIDSelector"
role="menu"
aria-haspopup>
<template #icon>
Expand Down Expand Up @@ -59,6 +60,7 @@ import { NcActions, NcActionButton } from '@nextcloud/vue'
import { Loading, Folder, Upload } from '../icons.js'
import { useIsPublicMixin } from '../Editor.provider.js'
import { BaseActionEntry } from './BaseActionEntry.js'
import { useMenuIDMixin } from './MenuBar.provider.js'
import {
useActionAttachmentPromptMixin,
useUploadingStateMixin,
Expand All @@ -80,6 +82,7 @@ export default {
useActionAttachmentPromptMixin,
useUploadingStateMixin,
useActionChooseLocalAttachmentMixin,
useMenuIDMixin,
],
computed: {
icon() {
Expand Down