Skip to content

⬆️ Upgrade dependencies #3071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
julien-nc merged 4 commits into from
Sep 30, 2022
Merged

⬆️ Upgrade dependencies #3071

julien-nc merged 4 commits into from
Sep 30, 2022

Conversation

@vinicius73
Copy link
Member

@vinicius73 vinicius73 commented Sep 29, 2022

No description provided.

@vinicius73 vinicius73 added this to the Nextcloud 26 milestone Sep 29, 2022
@vinicius73 vinicius73 requested review from a team, julien-nc, juliusknorr, max-nextcloud and mejo- and removed request for a team September 29, 2022 15:05
@julien-nc
Copy link
Member

julien-nc commented Sep 29, 2022

We get this error when inserting an image (upload or local). Seems like an issue when chaining operations:
image

@vinicius73 vinicius73 force-pushed the feature/upgrade-packages branch from 16a49ff to 8b5279e Compare September 30, 2022 07:52
⬆️ Upgrade dependencies
1d49a82 
also run npm dedup

Signed-off-by: Vinicius Reis <[email protected]>
@vinicius73 vinicius73 force-pushed the feature/upgrade-packages branch from 8b5279e to 1d49a82 Compare September 30, 2022 08:03
💚 fix cypress test (links)
33f4bf0 
add isolateTest command

Signed-off-by: Vinicius Reis <[email protected]>
@vinicius73
Copy link
Member Author

vinicius73 commented Sep 30, 2022

@eneiluj I've run npm dedup and it fixes the problem.
It seems we have 2 versions of linkifyjs

├─┬ @nextcloud/[email protected]
│ └─┬ [email protected]
│   └── [email protected]
└─┬ @tiptap/[email protected]
  └── [email protected]

julien-nc
julien-nc approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@julien-nc julien-nc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

  • emoji prefix ✔️
  • new link behaviour ✔️
  • image insertion ✔️

@julien-nc
Copy link
Member

julien-nc commented Sep 30, 2022

/compile

@nextcloud-command
Compile assets
2565914 
Signed-off-by: nextcloud-command <[email protected]>
@julien-nc julien-nc merged commit 2ecdc67 into master Sep 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the feature/upgrade-packages branch September 30, 2022 11:40
@vinicius73
Copy link
Member Author

vinicius73 commented Sep 30, 2022

/backport 1d49a82,1d49a82fe88548d585e840a60886dfa690246fb3,4dd0d93719072e72182b48792b6f25acaa2052f6 to stable25

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Sep 30, 2022

The backport to stable25 failed. Please do this backport manually.

@juliusknorr
Copy link
Member

juliusknorr commented Oct 11, 2022

@vinicius73 Mind to manually backport the cypress changes?

@juliusknorr
Copy link
Member

juliusknorr commented Oct 14, 2022

Relevant commit back ported with #3206

@blizzz blizzz mentioned this pull request Feb 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julien-nc julien-nc julien-nc approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr juliusknorr was automatically assigned from nextcloud/office

@mejo- mejo- Awaiting requested review from mejo- mejo- was automatically assigned from nextcloud/office

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

Assignees

No one assigned

Labels

dependencies: javascript

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

5 participants

@vinicius73 @julien-nc @juliusknorr @nextcloud-command