Set #content margin to 0 for direct editing #3148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable25 |
Member
Author
|
@juliushaertl this removes the blue borders in direct editing view (#2976), but I have no idea whether it also fixes direct editing in mobile clients (#3121). Could you test this locally to see whether it solves the issue for you? |
juliusknorr
approved these changes
Oct 11, 2022
`#content` has a default margin in Nextcloud 25, which breaks the layout for direct editing. Manually set it to 0 in order to fix direct editing. Fixes: #2976 Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
fix/direct_editing_layout
branch
from
34ab645 to
ba1bc2c
Compare
Member
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
|
The backport to stable25 failed. Please do this backport manually. |
Member
Author
|
/backport ba1bc2c to stable25 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#contenthas a default margin in Nextcloud 25, which breaks the layout for direct editing. Manually set it to 0 in order to fix direct editing.Fixes: #2976
Signed-off-by: Jonas [email protected]
Summary