Skip to content

fix: adjust margin for hr #3270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliusknorr merged 1 commit into from
Oct 18, 2022
Merged

fix: adjust margin for hr #3270

juliusknorr merged 1 commit into from
Oct 18, 2022

Conversation

@max-nextcloud
Copy link
Collaborator

@max-nextcloud max-nextcloud commented Oct 18, 2022 •
edited
Loading

Before:

Bildschirmfoto vom 2022-10-18 08-01-43

After:

Bildschirmfoto vom 2022-10-18 08-02-27

@max-nextcloud
Copy link
Collaborator Author

max-nextcloud commented Oct 18, 2022

I don't have much of an opinion on this. The 3em spacing was confusing people as they thought it added an additional line:
https://help.nextcloud.com/t/extra-lines-inserted-after-adding-hard-line-after-update-to-nc-22/124692/2

So I think 2em still provides enough separation while it's harder to be confused with empty lines.

@max-nextcloud
Copy link
Collaborator Author

max-nextcloud commented Oct 18, 2022

/compile amend /

@max-nextcloud @nextcloud-command
fix: adjust margin for hr
aa0f107 
fixes #1889.

Signed-off-by: Max <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@max-nextcloud max-nextcloud added 3. to review feature: formatting Features related to text formatting and node types design: papercut labels Oct 18, 2022
@juliusknorr juliusknorr merged commit 594993b into master Oct 18, 2022
@juliusknorr juliusknorr deleted the fix/1889-hr-margin branch October 18, 2022 09:18
@vinicius73 vinicius73 added this to the Nextcloud 25.0.1 milestone Oct 19, 2022
@vinicius73
Copy link
Member

vinicius73 commented Oct 19, 2022

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 19, 2022
Merged
1 task
jancborchardt
jancborchardt reviewed Oct 20, 2022
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, 2em is all good as also commented on the issue. :) Thanks!

@blizzz blizzz mentioned this pull request Feb 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jancborchardt jancborchardt jancborchardt left review comments

@juliusknorr juliusknorr juliusknorr approved these changes

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees

No one assigned

Labels

3. to review design: papercut feature: formatting Features related to text formatting and node types

Projects

None yet

Milestone

Nextcloud 25.0.1

Development

Successfully merging this pull request may close these issues.

Too much vertical spacing around horizontal line

5 participants

@max-nextcloud @vinicius73 @jancborchardt @juliusknorr