[stable25] Fix: relative link in RichWorkspace #3323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot-nextcloud
bot
requested review from
Raudius,
juliusknorr,
max-nextcloud,
mejo-,
skjnldsv,
susnux and
vinicius73
mejo-
previously approved these changes
Oct 27, 2022
mejo-
dismissed
their stale review
too fast, apparently there's manual work needed.
vinicius73
force-pushed
the
backport/3269/stable25
branch
from
9a21ce2 to
6f9dd8d
Compare
Member
|
/compile |
1 task
added 2 commits
November 7, 2022 17:44
Signed-off-by: Vinicius Reis <[email protected]>
Signed-off-by: Vinicius Reis <[email protected]>
max-nextcloud
force-pushed
the
backport/3269/stable25
branch
from
1b538fd to
2a9aaa8
Compare
Collaborator
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||
max-nextcloud
approved these changes
Nov 7, 2022
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Code looks good - very similar to the original PR.
New test is passing and failing cypress test is unrelated. So i think we should give this a go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #3269