Fix code blocks loosing the language hint on serialization #3330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
force-pushed
the
fix/code_block-language
branch
from
73677bb to
2805a12
Compare
Contributor
Author
|
/compile |
max-nextcloud
approved these changes
Oct 30, 2022
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Thanks for looking into this.
Fix looks right on point.
Haven't tried it myself - but since you added a test I'm confident it works. :D
`prosemirror-markdown` uses `params` attribute for the language hint whereas `tiptap` uses the `language` attribute. Signed-off-by: Ferdinand Thiessen <[email protected]>
mejo-
force-pushed
the
fix/code_block-language
branch
from
1f02080 to
b33ea75
Compare
Member
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
prosemirror-markdownusesparamsattribute for the language hint whereastiptapuses thelanguageattribute.