Skip to content

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Nov 7, 2022

  • ⚠️ This backport had conflicts and is incomplete

backport of #3356

@backportbot-nextcloud backportbot-nextcloud bot added the bug Something isn't working label Nov 7, 2022
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 24.0.8 milestone Nov 7, 2022
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 Conflicts

@cypress
Copy link

cypress bot commented Nov 7, 2022



Test summary

52 0 0 0


Run details

Project Text
Status Passed
Commit f208638 ℹ️
Started Nov 7, 2022 1:41 PM
Ended Nov 7, 2022 1:45 PM
Duration 03:16 💡
OS Linux Ubuntu - 20.04
Browser Electron 100

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@max-nextcloud max-nextcloud force-pushed the backport/3356/stable24 branch from ee8ec5c to a871730 Compare November 7, 2022 13:19
@max-nextcloud
Copy link
Collaborator

max-nextcloud commented Nov 7, 2022

@juliushaertl I also backported your older commit that changed the underlying code. It only cleans things up and adds types... so should be fine to backport. Also reduces the diff for future backports.

update: looks like the linter is still unhappy. Will need to fix separately.

@max-nextcloud max-nextcloud requested review from juliusknorr and removed request for marcelklehr and max-nextcloud November 7, 2022 13:22
@max-nextcloud max-nextcloud force-pushed the backport/3356/stable24 branch from a871730 to ceee256 Compare November 7, 2022 13:28
to have it available for the file put activities event

fixes nextcloud/android#10237
fixes #2821

Signed-off-by: Marcel Klehr <[email protected]>
@max-nextcloud max-nextcloud force-pushed the backport/3356/stable24 branch from ceee256 to d505a2d Compare November 7, 2022 13:35
@juliusknorr juliusknorr merged commit f754105 into stable24 Nov 7, 2022
@juliusknorr juliusknorr deleted the backport/3356/stable24 branch November 7, 2022 16:15
@max-nextcloud
Copy link
Collaborator

/backport to stable23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants