Refactor vuex store #3423
Merged
Refactor vuex store #3423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejo-
force-pushed
the
refactor/store
branch
from
ed2d970 to
ba23ff7
Compare
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||
mejo-
force-pushed
the
refactor/store
branch
4 times, most recently
from
e467587 to
dd6629f
Compare
Member
Author
|
/backport to stable25 |
mejo-
force-pushed
the
refactor/store
branch
from
dd6629f to
38a0263
Compare
Member
Author
|
/compile |
Member
Author
|
Cypress tests seem unrelated to me (same tests failing on other branches and no failures when running them locally), but I'll look into them. |
Also clean up some cruft code from outline implementation. Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
When a component from the NPM package is used by a vue app with an own vuex store, we have to expand this store with our text module. Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
refactor/store
branch
from
794f4c1 to
58186ec
Compare
Member
Author
|
/compile amend |
Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
refactor/store
branch
from
58186ec to
7537f87
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move text store into a namespaced module and load it if we already have a store - e.g. when using the
RichTextReadercomponent via NPM module in a vue app that has a store on its own (like Collectives).This is a prerequisite for using features that require the store (e.g. outline view) in Collectives.